From 128739dc46f79457fb1848b4ef63c318cd1bb3f1 Mon Sep 17 00:00:00 2001 From: Irene Blanco Date: Tue, 7 Jan 2025 10:54:39 +0100 Subject: [PATCH] [APM] Attempt to fix flaky test in service_group_count.spec.ts (#204543) ## Summary Fixes https://github.com/elastic/kibana/issues/201267 Before migrating the API tests to be deployment-agnostic, we had already seen some flaky results for this test (https://github.com/elastic/kibana/issues/197912). After completing the migration, the error occurred again. This PR aims to fix the potential issue by ensuring that all existing alerts are cleared before creating the alerts used in the test case. Co-authored-by: jennypavlova --- .../service_group_count.spec.ts | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/service_groups/service_group_count/service_group_count.spec.ts b/x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/service_groups/service_group_count/service_group_count.spec.ts index 08816f01d0f2b..d70d6ba0aedca 100644 --- a/x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/service_groups/service_group_count/service_group_count.spec.ts +++ b/x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/service_groups/service_group_count/service_group_count.spec.ts @@ -27,6 +27,16 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon const start = Date.now() - 24 * 60 * 60 * 1000; const end = Date.now(); + const cleanUpAlerts = ({ roleAuthc, ruleId }: { roleAuthc: RoleCredentials; ruleId: string }) => { + return alertingApi.cleanUpAlerts({ + roleAuthc, + ruleId, + alertIndexName: APM_ALERTS_INDEX, + connectorIndexName: APM_ACTION_VARIABLE_INDEX, + consumer: 'apm', + }); + }; + describe('Service group counts', () => { let synthbeansServiceGroupId: string; let opbeansServiceGroupId: string; @@ -73,6 +83,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon before(async () => { roleAuthc = await samlAuth.createM2mApiKeyWithRoleScope('admin'); + await cleanUpAlerts({ roleAuthc, ruleId }); const createdRule = await alertingApi.createRule({ name: 'Latency threshold | synth-go', params: { @@ -94,13 +105,7 @@ export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderCon }); after(async () => { - await alertingApi.cleanUpAlerts({ - roleAuthc, - ruleId, - alertIndexName: APM_ALERTS_INDEX, - connectorIndexName: APM_ACTION_VARIABLE_INDEX, - consumer: 'apm', - }); + await cleanUpAlerts({ roleAuthc, ruleId }); await samlAuth.invalidateM2mApiKeyWithRoleScope(roleAuthc); });