From 0f6c961174c912b8ae9091f0f880f6a092d5aaee Mon Sep 17 00:00:00 2001
From: Bryce Buchanan <75274611+bryce-b@users.noreply.github.com>
Date: Tue, 5 Nov 2024 08:27:05 -0800
Subject: [PATCH] [ci] re-enabled 'transaction-details' tests (#198689)

## Summary

Reenables `transaction_details` and adds additional timeout.
I went through cypress tests history and it appears the initial attempt
to fix this didn't add a timeout increase to `'shows top errors table'`.
I've added this and it appears the issue is resolved in both locally and
on the ci.
---
 .../observability_solution/apm/ftr_e2e/README.md     |  2 +-
 .../transaction_details/transaction_details.cy.ts    | 12 +++++-------
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/README.md b/x-pack/plugins/observability_solution/apm/ftr_e2e/README.md
index 8336c037ff21d..ecdb37a5f5229 100644
--- a/x-pack/plugins/observability_solution/apm/ftr_e2e/README.md
+++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/README.md
@@ -1,6 +1,6 @@
 # APM E2E
 
-APM uses [FTR](../../../../../packages/kbn-test/README.md) (functional test runner) and [Cypress](https://www.cypress.io/) to run the e2e tests. The tests are located at `kibana/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/integration`.
+APM uses [FTR](../../../../../packages/kbn-test/README.mdx) (functional test runner) and [Cypress](https://www.cypress.io/) to run the e2e tests. The tests are located at `kibana/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/integration`.
 
 ## Tips and best practices
 
diff --git a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts
index 3ae431f5d3299..0fc1b609b14ba 100644
--- a/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts
+++ b/x-pack/plugins/observability_solution/apm/ftr_e2e/cypress/e2e/transaction_details/transaction_details.cy.ts
@@ -16,7 +16,7 @@ const timeRange = {
   rangeTo: end,
 };
 // flaky
-describe.skip('Transaction details', () => {
+describe('Transaction details', () => {
   before(() => {
     synthtrace.index(
       opbeans({
@@ -34,8 +34,7 @@ describe.skip('Transaction details', () => {
     cy.loginAsViewerUser();
   });
 
-  // skipping this as it´s been failing a lot lately, more information here https://github.com/elastic/kibana/issues/197386
-  it.skip('shows transaction name and transaction charts', () => {
+  it('shows transaction name and transaction charts', () => {
     cy.intercept('GET', '/internal/apm/services/opbeans-java/transactions/charts/latency?*').as(
       'transactionLatencyRequest'
     );
@@ -61,7 +60,7 @@ describe.skip('Transaction details', () => {
         '@transactionThroughputRequest',
         '@transactionFailureRateRequest',
       ],
-      { timeout: 60000 }
+      { timeout: 30000 }
     ).spread((latencyInterception, throughputInterception, failureRateInterception) => {
       expect(latencyInterception.request.query.transactionName).to.be.eql('GET /api/product');
 
@@ -107,8 +106,7 @@ describe.skip('Transaction details', () => {
     );
     cy.contains('Create SLO');
   });
-  // skipping this as it´s been failing a lot lately, more information here https://github.com/elastic/kibana/issues/197386
-  it.skip('shows top errors table', () => {
+  it('shows top errors table', () => {
     cy.visitKibana(
       `/app/apm/services/opbeans-java/transactions/view?${new URLSearchParams({
         ...timeRange,
@@ -116,7 +114,7 @@ describe.skip('Transaction details', () => {
       })}`
     );
 
-    cy.contains('Top 5 errors');
+    cy.contains('Top 5 errors', { timeout: 30000 });
     cy.getByTestSubj('topErrorsForTransactionTable').contains('a', '[MockError] Foo').click();
     cy.url().should('include', 'opbeans-java/errors');
   });