From 0eac89c739cd95d4502db4b8513fa285871b3198 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Thu, 31 Oct 2024 21:31:49 +1100
Subject: [PATCH] [8.16] [CI] Quiet quickcheck i18n output (#197871) (#198472)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[CI] Quiet quickcheck i18n output
(#197871)](https://github.com/elastic/kibana/pull/197871)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2024-10-31T08:47:17Z","message":"[CI]
Quiet quickcheck i18n output (#197871)\n\n## Summary\r\nThe i18n check
spews out ~5k lines of log. This makes it difficult to\r\nspot any
errors, or even break the check through some buffer issue.\r\n\r\nThis
PR quiets output from i18n quick check, yet keeping the
error\r\noutputs.\r\n\r\nWe've tested it in
https://github.com/elastic/kibana/pull/194379, and\r\nlocally (to see if
we still see the errors) - it seems to have fixed\r\nerrors from
@pgayvallet 's case.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic
Machine
<elasticmachine@users.noreply.github.com>","sha":"2162c56b590da3545382739b4f865576f3b088b7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0","backport:version"],"title":"[CI]
Quiet quickcheck i18n
output","number":197871,"url":"https://github.com/elastic/kibana/pull/197871","mergeCommit":{"message":"[CI]
Quiet quickcheck i18n output (#197871)\n\n## Summary\r\nThe i18n check
spews out ~5k lines of log. This makes it difficult to\r\nspot any
errors, or even break the check through some buffer issue.\r\n\r\nThis
PR quiets output from i18n quick check, yet keeping the
error\r\noutputs.\r\n\r\nWe've tested it in
https://github.com/elastic/kibana/pull/194379, and\r\nlocally (to see if
we still see the errors) - it seems to have fixed\r\nerrors from
@pgayvallet 's case.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic
Machine
<elasticmachine@users.noreply.github.com>","sha":"2162c56b590da3545382739b4f865576f3b088b7"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197871","number":197871,"mergeCommit":{"message":"[CI]
Quiet quickcheck i18n output (#197871)\n\n## Summary\r\nThe i18n check
spews out ~5k lines of log. This makes it difficult to\r\nspot any
errors, or even break the check through some buffer issue.\r\n\r\nThis
PR quiets output from i18n quick check, yet keeping the
error\r\noutputs.\r\n\r\nWe've tested it in
https://github.com/elastic/kibana/pull/194379, and\r\nlocally (to see if
we still see the errors) - it seems to have fixed\r\nerrors from
@pgayvallet 's case.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic
Machine
<elasticmachine@users.noreply.github.com>","sha":"2162c56b590da3545382739b4f865576f3b088b7"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
---
 .buildkite/scripts/steps/checks/i18n.sh  |  2 +-
 src/dev/i18n_tools/bin/run_i18n_check.ts | 18 +++++++++---------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/.buildkite/scripts/steps/checks/i18n.sh b/.buildkite/scripts/steps/checks/i18n.sh
index 090512e391d7c..f23ed2d63759e 100755
--- a/.buildkite/scripts/steps/checks/i18n.sh
+++ b/.buildkite/scripts/steps/checks/i18n.sh
@@ -5,4 +5,4 @@ set -euo pipefail
 source .buildkite/scripts/common/util.sh
 
 echo --- Check i18n
-node scripts/i18n_check
+node scripts/i18n_check --quiet
diff --git a/src/dev/i18n_tools/bin/run_i18n_check.ts b/src/dev/i18n_tools/bin/run_i18n_check.ts
index 9d7265f84520f..ff00148ab3012 100644
--- a/src/dev/i18n_tools/bin/run_i18n_check.ts
+++ b/src/dev/i18n_tools/bin/run_i18n_check.ts
@@ -9,7 +9,6 @@
 
 import { Listr } from 'listr2';
 import { run } from '@kbn/dev-cli-runner';
-import { ToolingLog } from '@kbn/tooling-log';
 import { getTimeReporter } from '@kbn/ci-stats-reporter';
 import { isFailError } from '@kbn/dev-cli-errors';
 import { I18nCheckTaskContext, MessageDescriptor } from '../types';
@@ -24,13 +23,7 @@ import {
 import { TaskReporter } from '../utils/task_reporter';
 import { flagFailError, isDefined, undefinedOrBoolean } from '../utils/verify_bin_flags';
 
-const toolingLog = new ToolingLog({
-  level: 'info',
-  writeTo: process.stdout,
-});
-
 const runStartTime = Date.now();
-const reportTime = getTimeReporter(toolingLog, 'scripts/i18n_check');
 
 const skipOnNoTranslations = ({ config }: I18nCheckTaskContext) =>
   !config?.translations.length && 'No translations found.';
@@ -50,9 +43,13 @@ run(
       namespace: namespace,
       fix = false,
       path,
+      silent,
+      quiet,
     },
     log,
   }) => {
+    const reportTime = getTimeReporter(log, 'scripts/i18n_check');
+
     if (
       fix &&
       (isDefined(ignoreIncompatible) ||
@@ -131,13 +128,15 @@ run(
       {
         concurrent: false,
         exitOnError: true,
-        renderer: process.env.CI ? 'verbose' : ('default' as any),
+        forceTTY: false,
+        renderer:
+          ((silent || quiet) && 'silent') || (process.env.CI ? 'verbose' : ('default' as any)),
       }
     );
 
     try {
       const messages: Map<string, MessageDescriptor[]> = new Map();
-      const taskReporter = new TaskReporter({ toolingLog });
+      const taskReporter = new TaskReporter({ toolingLog: log });
       await list.run({ messages, taskReporter });
 
       reportTime(runStartTime, 'total', {
@@ -150,6 +149,7 @@ run(
         reportTime(runStartTime, 'error', {
           success: false,
         });
+        log.error(error);
       } else {
         log.error('Unhandled exception!');
         log.error(error);