From 09209d4c7bb00afab9b1aff8c4611a15d0cb664d Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Sat, 5 Oct 2024 04:04:49 +1000
Subject: [PATCH] =?UTF-8?q?[8.x]=20Disable=20=E2=80=9CAssign=20roles=20to?=
 =?UTF-8?q?=20space=E2=80=9D=20button=20if=20no=20privileges=20are=20selec?=
 =?UTF-8?q?ted=20(#194874)=20(#195118)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Backport

This will backport the following commits from `main` to `8.x`:
- [Disable “Assign roles to space” button if no privileges are selected
(#194874)](https://github.com/elastic/kibana/pull/194874)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tim
Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-04T16:10:17Z","message":"Disable
“Assign roles to space” button if no privileges are selected
(#194874)\n\n## Summary\r\n\r\nDisable “Assign roles to space” button if
no base privileges or features\r\nare
selected\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4efa921b-6cc4-4496-99f7-0ee79dd318be\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/fc8fe809-f03a-4f0b-a961-328596c9b2c7\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"381c430db53fe82db454da4589803bb9cf447dd5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","v8.16.0","backport:version"],"title":"Disable
“Assign roles to space” button if no privileges are
selected","number":194874,"url":"https://github.com/elastic/kibana/pull/194874","mergeCommit":{"message":"Disable
“Assign roles to space” button if no privileges are selected
(#194874)\n\n## Summary\r\n\r\nDisable “Assign roles to space” button if
no base privileges or features\r\nare
selected\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4efa921b-6cc4-4496-99f7-0ee79dd318be\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/fc8fe809-f03a-4f0b-a961-328596c9b2c7\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"381c430db53fe82db454da4589803bb9cf447dd5"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194874","number":194874,"mergeCommit":{"message":"Disable
“Assign roles to space” button if no privileges are selected
(#194874)\n\n## Summary\r\n\r\nDisable “Assign roles to space” button if
no base privileges or features\r\nare
selected\r\n\r\n**Before**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4efa921b-6cc4-4496-99f7-0ee79dd318be\r\n\r\n**After**\r\n\r\n\r\nhttps://github.com/user-attachments/assets/fc8fe809-f03a-4f0b-a961-328596c9b2c7\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"381c430db53fe82db454da4589803bb9cf447dd5"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
---
 .../space_assign_role_privilege_form.test.tsx | 26 +++++++++++++++++++
 .../space_assign_role_privilege_form.tsx      | 25 ++++++++++++++++--
 2 files changed, 49 insertions(+), 2 deletions(-)

diff --git a/x-pack/plugins/spaces/public/management/edit_space/roles/component/space_assign_role_privilege_form.test.tsx b/x-pack/plugins/spaces/public/management/edit_space/roles/component/space_assign_role_privilege_form.test.tsx
index 9150f0c211adb..a7cc54820774d 100644
--- a/x-pack/plugins/spaces/public/management/edit_space/roles/component/space_assign_role_privilege_form.test.tsx
+++ b/x-pack/plugins/spaces/public/management/edit_space/roles/component/space_assign_role_privilege_form.test.tsx
@@ -160,6 +160,32 @@ describe('PrivilegesRolesForm', () => {
     expect(screen.getByTestId('space-assign-role-create-roles-privilege-button')).toBeDisabled();
   });
 
+  it('renders with the assign roles button disabled when no base privileges or feature privileges are selected', async () => {
+    getRolesSpy.mockResolvedValue([]);
+    getAllKibanaPrivilegeSpy.mockResolvedValue(createRawKibanaPrivileges(kibanaFeatures));
+
+    const roles: Role[] = [
+      createRole('test_role_1', [{ base: [], feature: {}, spaces: [space.id] }]),
+    ];
+
+    renderPrivilegeRolesForm({
+      preSelectedRoles: roles,
+    });
+
+    await waitFor(() => null);
+
+    expect(screen.getByTestId(`${FEATURE_PRIVILEGES_READ}-privilege-button`)).toHaveAttribute(
+      'aria-pressed',
+      String(false)
+    );
+
+    expect(
+      screen.getByTestId('space-assign-role-privilege-customization-form')
+    ).toBeInTheDocument();
+
+    expect(screen.getByTestId('space-update-role-create-roles-privilege-button')).toBeDisabled();
+  });
+
   it('preselects the privilege of the selected role when one is provided', async () => {
     getRolesSpy.mockResolvedValue([]);
     getAllKibanaPrivilegeSpy.mockResolvedValue(createRawKibanaPrivileges(kibanaFeatures));
diff --git a/x-pack/plugins/spaces/public/management/edit_space/roles/component/space_assign_role_privilege_form.tsx b/x-pack/plugins/spaces/public/management/edit_space/roles/component/space_assign_role_privilege_form.tsx
index 276efb7f92526..23a7383a01a06 100644
--- a/x-pack/plugins/spaces/public/management/edit_space/roles/component/space_assign_role_privilege_form.tsx
+++ b/x-pack/plugins/spaces/public/management/edit_space/roles/component/space_assign_role_privilege_form.tsx
@@ -543,11 +543,32 @@ export const PrivilegesRolesForm: FC<PrivilegesRolesFormProps> = (props) => {
     );
   };
 
+  const canSave = useCallback(() => {
+    if (selectedRoles.length === 0) {
+      return false;
+    }
+
+    const form = roleCustomizationAnchor.value.kibana[roleCustomizationAnchor.privilegeIndex] ?? {};
+    const formBase = form.base ?? [];
+    const formFeature = form.feature ?? {};
+
+    // ensure that the form has base privileges or has selected features that are valid
+    if (
+      formBase.length === 0 &&
+      (Object.keys(formFeature).length === 0 ||
+        Object.values(formFeature).every((privileges) => privileges.length === 0))
+    ) {
+      return false;
+    }
+
+    return true;
+  }, [selectedRoles, roleCustomizationAnchor]);
+
   const getSaveButton = useCallback(() => {
     return (
       <EuiButton
         fill
-        disabled={!selectedRoles.length}
+        disabled={!canSave()}
         isLoading={assigningToRole}
         onClick={() => assignRolesToSpace()}
         data-test-subj={`space-${
@@ -563,7 +584,7 @@ export const PrivilegesRolesForm: FC<PrivilegesRolesFormProps> = (props) => {
             })}
       </EuiButton>
     );
-  }, [assignRolesToSpace, assigningToRole, selectedRoles.length]);
+  }, [assignRolesToSpace, assigningToRole, canSave]);
 
   return (
     <React.Fragment>