-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update titles in 'Deployment models' section #1512
base: main
Are you sure you want to change the base?
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@eedugon I spoke with @nimarezainia about this and we're thinking that the change I have above might not be good:
I think you're right that the titles are inconsistent. So instead maybe we should change "Deploy Fleet Server on premises and Elasticsearch on Cloud" to just "Deploy on premises and Elasticsearch on Cloud", like this: What do you think? |
I totally agree on that.
mmm I clearly disagree here :) IMHO, those 2 docs are 95% / 98% about Fleet Server only, and Fleet Server installation is the clear and main goal of the docs. On those two docs, everything, all the paragraphs and sections, are about the Fleet Server. Except very minor sentences or lines. Of course to install the fleet server we have to setup fleet (a policy, an integration, etc), but that's like part of the process that has the goal of installing / deploying the fleet server itself. Also those docs don't cover the installation of the future Elastic Agents, so more reasons to consider them focused mainly on the Fleet Server component of the Fleet ecosystem. Anyway, I don't think these names are super important, and I'm happy with whatever you and @nimarezainia prefer, but it's just that the current names have created confusion, and I'll share an example: Colleagues from support asked me a few weeks ago where we had the Fleet Server installation docs (for on-premises), as they were clearly identified in 7.17 docs and they couldn't find them in the current docs.
None of the names helped anyone to realize that they were about Deploying / Installing the Fleet Server, it's not intuitive at all when the docs are 95% about that. But as I said I'm ok with cancelling the change. the question now is... I'm creating the doc |
@nimarezainia just FYI in case you have thoughts on the "deployment models" naming and Edu's comment above. |
Edu had some feedback on improving the titles in the "Deployment models" section to make more clear that this is about Fleet, and also to improve consistency.
Closes: #1511
Original:
Updated: