Add support for custom hostfs in linux metrics, cleanup linux code #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
enhancement
andrewkroh
reviewed
Dec 7, 2023
| @@ -52,6 +52,16 @@ func Host() (types.Host, error) { | |||
| return provider.Host() | |||
| } | |||
|
|
|||
| // HostFS is the same as Host, but allows for a custom root hostfs mountpoint | |||
| // a custom filesystem root is only supported on linux, and this will fallback to the default provider on other platforms | |||
| func HostFS(hostfs string) (types.Host, error) { | |||
There was a problem hiding this comment.
Have you considered using the option pattern to enhance the existing APIs? My initial thought is that this would better because it keeps the api surface of the package small and direct.
There was a problem hiding this comment.
I actually did think of that, but the idea of making some ...Option arg for something where there's only ever going to be a single option felt kind of deceptive or non-obvious?
There was a problem hiding this comment.
It's possible that there could be more options in the future so I'm not worried about there only being a single one now. I think options this would be preferable to doubling the api surface to support this feature.
|
Closing this in favor of #226. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12
This adds a set of new public methods to
system.goto allow for metrics from a custom filesystem root under linux.The API design feels a bit awkward at points, but my goal was to make a non-breaking change that mostly followed the existing design idioms of the library.
The underlying linux implementation already had support for a custom filesystem root, but the option wasn't exposed publicly, so this is a fairly small change.