Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ILM customization tutorial and screenshots #117925

Closed
dakrone opened this issue Dec 3, 2024 · 12 comments
Closed

Update ILM customization tutorial and screenshots #117925

dakrone opened this issue Dec 3, 2024 · 12 comments
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes >enhancement Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team

Comments

@dakrone
Copy link
Member

dakrone commented Dec 3, 2024

Description

The documentation at https://www.elastic.co/guide/en/elasticsearch/reference/current/example-using-index-lifecycle-policy.html uses older language:

  • It mentions "50gb" as the index size, rather than our current recommendation, which is the size of a single primary shard.
  • The screenshots are of an older Kibana dashboard, for example the old version:

image

versus a newer version of the API:

Image

@dakrone dakrone added :Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes >enhancement labels Dec 3, 2024
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Dec 3, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@satyyam11
Copy link
Contributor

Can I help?

@dakrone
Copy link
Member Author

dakrone commented Dec 3, 2024

@satyyam11 certainly, feel free to open a PR for this, https://github.com/elastic/elasticsearch/blob/main/docs/reference/ilm/example-index-lifecycle-policy.asciidoc?plain=1 is the location of the file.

@satyyam11
Copy link
Contributor

I have raised a PR
but there Image
seems to be a issue with it can you help

@satyyam11
Copy link
Contributor

At first the issue was that document wasn't signed but i did that now its showing this, should i start all over again?

@satyyam11
Copy link
Contributor

Also I want to update the image and replace it with the new screenshot can you tell in which folder are they located? so that I can do that

@satyyam11
Copy link
Contributor

Shalll I raise a PR for image change as well?

@dakrone
Copy link
Member Author

dakrone commented Dec 6, 2024

I commented on the PR that you opened (#117940). We should do the text and image updates at the same time.

@satyyam11
Copy link
Contributor

okay so you don't accept this PR
I'll raise a new one with both the changes.
Is that okay?

@satyyam11
Copy link
Contributor

I have raised a new PR #118148 and it has both text and image changes.

@dakrone
Copy link
Member Author

dakrone commented Dec 17, 2024

Resolved by #118148

@dakrone dakrone closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes >enhancement Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team
Projects
None yet
Development

No branches or pull requests

3 participants