Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output the public API only in the stack OpenAPI schema #3308

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Output the public API only in the stack OpenAPI schema #3308

wants to merge 3 commits into from
+38 −430

Conversation

swallez
Copy link
Member

@swallez swallez commented Dec 13, 2024

Keep only public items in the stack OpenAPI export

Fixes #3300

@swallez swallez requested a review from Anaethelion December 13, 2024 14:14
@swallez swallez requested a review from a team as a code owner December 13, 2024 14:14
@swallez swallez mentioned this pull request Dec 13, 2024
Open
Anaethelion
Anaethelion reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

elasticsearch-specification/compiler-rs/clients_schema_to_openapi/src/main.rs

Line 86 in 3f5c846

clients_schema::Flavor::Stack.available(a)
?

We should probably keep these two in sync.

@swallez
Copy link
Member Author

swallez commented Dec 13, 2024

We should probably keep these two in sync.

Good catch. I have refactored the code so that the filtering is done in a single location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anaethelion Anaethelion Anaethelion left review comments

@l-trotta l-trotta l-trotta approved these changes

Assignees
No one assigned
Labels
backport 8.x backport 8.17 compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling visibility=private
3 participants
@swallez @Anaethelion @l-trotta