From cb520f80940b7bf4cf0660c0b20e907ba58cf72a Mon Sep 17 00:00:00 2001
From: Laura Trotta <laura.trotta@elastic.co>
Date: Thu, 5 Dec 2024 09:50:45 +0100
Subject: [PATCH] correct discovery nodes optionals

---
 output/openapi/elasticsearch-openapi.json | 11 +++++++++--
 output/schema/schema-serverless.json      | 12 ++++++------
 output/schema/schema.json                 | 14 +++++++-------
 output/typescript/types.ts                | 14 +++++++-------
 specification/ml/_types/DiscoveryNode.ts  | 14 +++++++-------
 5 files changed, 36 insertions(+), 29 deletions(-)

diff --git a/output/openapi/elasticsearch-openapi.json b/output/openapi/elasticsearch-openapi.json
index a267644669..8403f3a134 100644
--- a/output/openapi/elasticsearch-openapi.json
+++ b/output/openapi/elasticsearch-openapi.json
@@ -74138,7 +74138,8 @@
           "name",
           "ephemeral_id",
           "id",
-          "transport_address"
+          "transport_address",
+          "attributes"
         ]
       },
       "ml._types:DatafeedTimingStats": {
@@ -75193,7 +75194,13 @@
         },
         "required": [
           "ephemeral_id",
-          "transport_address"
+          "transport_address",
+          "external_id",
+          "attributes",
+          "roles",
+          "version",
+          "min_index_version",
+          "max_index_version"
         ]
       },
       "ml._types:ModelSnapshot": {
diff --git a/output/schema/schema-serverless.json b/output/schema/schema-serverless.json
index 61b15eecdc..82de1f0d06 100644
--- a/output/schema/schema-serverless.json
+++ b/output/schema/schema-serverless.json
@@ -95220,7 +95220,7 @@
         },
         {
           "name": "external_id",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "instance_of",
             "type": {
@@ -95231,7 +95231,7 @@
         },
         {
           "name": "attributes",
-          "required": false,
+          "required": true,
           "type": {
             "key": {
               "kind": "instance_of",
@@ -95253,7 +95253,7 @@
         },
         {
           "name": "roles",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "array_of",
             "value": {
@@ -95267,7 +95267,7 @@
         },
         {
           "name": "version",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "instance_of",
             "type": {
@@ -95278,7 +95278,7 @@
         },
         {
           "name": "min_index_version",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "instance_of",
             "type": {
@@ -95289,7 +95289,7 @@
         },
         {
           "name": "max_index_version",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "instance_of",
             "type": {
diff --git a/output/schema/schema.json b/output/schema/schema.json
index 37abf16c40..ec90fa1e78 100644
--- a/output/schema/schema.json
+++ b/output/schema/schema.json
@@ -155519,7 +155519,7 @@
         },
         {
           "name": "attributes",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "dictionary_of",
             "key": {
@@ -155584,7 +155584,7 @@
         },
         {
           "name": "external_id",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "instance_of",
             "type": {
@@ -155595,7 +155595,7 @@
         },
         {
           "name": "attributes",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "dictionary_of",
             "key": {
@@ -155617,7 +155617,7 @@
         },
         {
           "name": "roles",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "array_of",
             "value": {
@@ -155631,7 +155631,7 @@
         },
         {
           "name": "version",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "instance_of",
             "type": {
@@ -155642,7 +155642,7 @@
         },
         {
           "name": "min_index_version",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "instance_of",
             "type": {
@@ -155653,7 +155653,7 @@
         },
         {
           "name": "max_index_version",
-          "required": false,
+          "required": true,
           "type": {
             "kind": "instance_of",
             "type": {
diff --git a/output/typescript/types.ts b/output/typescript/types.ts
index 97dc7875ec..c1c9b72dec 100644
--- a/output/typescript/types.ts
+++ b/output/typescript/types.ts
@@ -14225,19 +14225,19 @@ export interface MlDiscoveryNodeCompact {
   ephemeral_id: Id
   id: Id
   transport_address: TransportAddress
-  attributes?: Record<string, string>
+  attributes: Record<string, string>
 }
 
 export interface MlDiscoveryNodeContent {
   name?: Name
   ephemeral_id: Id
   transport_address: TransportAddress
-  external_id?: string
-  attributes?: Record<string, string>
-  roles?: string[]
-  version?: VersionString
-  min_index_version?: integer
-  max_index_version?: integer
+  external_id: string
+  attributes: Record<string, string>
+  roles: string[]
+  version: VersionString
+  min_index_version: integer
+  max_index_version: integer
 }
 
 export type MlExcludeFrequent = 'all' | 'none' | 'by' | 'over'
diff --git a/specification/ml/_types/DiscoveryNode.ts b/specification/ml/_types/DiscoveryNode.ts
index 86e64022d7..578179f9cb 100644
--- a/specification/ml/_types/DiscoveryNode.ts
+++ b/specification/ml/_types/DiscoveryNode.ts
@@ -28,12 +28,12 @@ export class DiscoveryNodeContent {
   name?: Name
   ephemeral_id: Id
   transport_address: TransportAddress
-  external_id?: string
-  attributes?: Dictionary<string, string>
-  roles?: string[]
-  version?: VersionString
-  min_index_version?: integer
-  max_index_version?: integer
+  external_id: string
+  attributes: Dictionary<string, string>
+  roles: string[]
+  version: VersionString
+  min_index_version: integer
+  max_index_version: integer
 }
 
 /**
@@ -44,5 +44,5 @@ export class DiscoveryNodeCompact {
   ephemeral_id: Id
   id: Id
   transport_address: TransportAddress
-  attributes?: Dictionary<string, string>
+  attributes: Dictionary<string, string>
 }