From 2bb4d0cc61ca56099a1dd4e1dee4bdb1bf7e4362 Mon Sep 17 00:00:00 2001 From: Vitalii Mahas Date: Thu, 20 Jun 2024 15:10:41 +0200 Subject: [PATCH] Add missing shard_min_doc_count to TermsAggregation (#2175) Co-authored-by: Quentin Pradet --- output/schema/schema.json | 40 +++++++++++++-------- output/typescript/types.ts | 1 + specification/_types/aggregations/bucket.ts | 5 +++ 3 files changed, 32 insertions(+), 14 deletions(-) diff --git a/output/schema/schema.json b/output/schema/schema.json index d6c65a5799..8f8da758e3 100644 --- a/output/schema/schema.json +++ b/output/schema/schema.json @@ -50469,7 +50469,7 @@ "name": "AggregateOrder", "namespace": "_types.aggregations" }, - "specLocation": "_types/aggregations/bucket.ts#L978-L980", + "specLocation": "_types/aggregations/bucket.ts#L983-L985", "type": { "items": [ { @@ -52975,7 +52975,7 @@ } } ], - "specLocation": "_types/aggregations/bucket.ts#L1040-L1104" + "specLocation": "_types/aggregations/bucket.ts#L1045-L1109" }, { "codegenNames": [ @@ -52987,7 +52987,7 @@ "name": "CategorizeTextAnalyzer", "namespace": "_types.aggregations" }, - "specLocation": "_types/aggregations/bucket.ts#L1106-L1109", + "specLocation": "_types/aggregations/bucket.ts#L1111-L1114", "type": { "items": [ { @@ -53655,7 +53655,7 @@ } } ], - "specLocation": "_types/aggregations/bucket.ts#L1111-L1115" + "specLocation": "_types/aggregations/bucket.ts#L1116-L1120" }, { "inherits": { @@ -55052,7 +55052,7 @@ } } ], - "specLocation": "_types/aggregations/bucket.ts#L1162-L1186" + "specLocation": "_types/aggregations/bucket.ts#L1167-L1191" }, { "attachedBehaviors": [ @@ -55152,7 +55152,7 @@ } } ], - "specLocation": "_types/aggregations/bucket.ts#L1148-L1160" + "specLocation": "_types/aggregations/bucket.ts#L1153-L1165" }, { "kind": "enum", @@ -56908,7 +56908,7 @@ } } ], - "specLocation": "_types/aggregations/bucket.ts#L1117-L1146" + "specLocation": "_types/aggregations/bucket.ts#L1122-L1151" }, { "attachedBehaviors": [ @@ -61614,6 +61614,18 @@ } } }, + { + "description": "Regulates the certainty a shard has if the term should actually be added to the candidate list or not with respect to the `min_doc_count`.\nTerms will only be considered if their local shard frequency within the set is higher than the `shard_min_doc_count`.", + "name": "shard_min_doc_count", + "required": false, + "type": { + "kind": "instance_of", + "type": { + "name": "long", + "namespace": "_types" + } + } + }, { "description": "The number of candidate terms produced by each shard.\nBy default, `shard_size` will be automatically estimated based on the number of shards and the `size` parameter.", "name": "shard_size", @@ -61663,7 +61675,7 @@ } } ], - "specLocation": "_types/aggregations/bucket.ts#L912-L972" + "specLocation": "_types/aggregations/bucket.ts#L912-L977" }, { "kind": "enum", @@ -61681,7 +61693,7 @@ "name": "TermsAggregationCollectMode", "namespace": "_types.aggregations" }, - "specLocation": "_types/aggregations/bucket.ts#L982-L991" + "specLocation": "_types/aggregations/bucket.ts#L987-L996" }, { "kind": "enum", @@ -61703,7 +61715,7 @@ "name": "TermsAggregationExecutionHint", "namespace": "_types.aggregations" }, - "specLocation": "_types/aggregations/bucket.ts#L993-L998" + "specLocation": "_types/aggregations/bucket.ts#L998-L1003" }, { "attachedBehaviors": [ @@ -61745,7 +61757,7 @@ "name": "TermsExclude", "namespace": "_types.aggregations" }, - "specLocation": "_types/aggregations/bucket.ts#L1003-L1004", + "specLocation": "_types/aggregations/bucket.ts#L1008-L1009", "type": { "items": [ { @@ -61780,7 +61792,7 @@ "name": "TermsInclude", "namespace": "_types.aggregations" }, - "specLocation": "_types/aggregations/bucket.ts#L1000-L1001", + "specLocation": "_types/aggregations/bucket.ts#L1005-L1006", "type": { "items": [ { @@ -61843,7 +61855,7 @@ } } ], - "specLocation": "_types/aggregations/bucket.ts#L1006-L1015" + "specLocation": "_types/aggregations/bucket.ts#L1011-L1020" }, { "kind": "interface", @@ -62570,7 +62582,7 @@ } } ], - "specLocation": "_types/aggregations/bucket.ts#L1017-L1038" + "specLocation": "_types/aggregations/bucket.ts#L1022-L1043" }, { "attachedBehaviors": [ diff --git a/output/typescript/types.ts b/output/typescript/types.ts index d77fffd190..0fc3aec26a 100644 --- a/output/typescript/types.ts +++ b/output/typescript/types.ts @@ -4151,6 +4151,7 @@ export interface AggregationsTermsAggregation extends AggregationsBucketAggregat value_type?: string order?: AggregationsAggregateOrder script?: Script + shard_min_doc_count?: long shard_size?: integer show_term_doc_count_error?: boolean size?: integer diff --git a/specification/_types/aggregations/bucket.ts b/specification/_types/aggregations/bucket.ts index 120a2099bf..c3343f096a 100644 --- a/specification/_types/aggregations/bucket.ts +++ b/specification/_types/aggregations/bucket.ts @@ -954,6 +954,11 @@ export class TermsAggregation extends BucketAggregationBase { */ order?: AggregateOrder script?: Script + /** + * Regulates the certainty a shard has if the term should actually be added to the candidate list or not with respect to the `min_doc_count`. + * Terms will only be considered if their local shard frequency within the set is higher than the `shard_min_doc_count`. + */ + shard_min_doc_count?: long /** * The number of candidate terms produced by each shard. * By default, `shard_size` will be automatically estimated based on the number of shards and the `size` parameter.