From 68d07e6e9dc87dc6d246f2d46c896a960c165a2d Mon Sep 17 00:00:00 2001 From: Josh Mock Date: Thu, 2 Nov 2023 11:34:46 -0500 Subject: [PATCH 1/2] Fix version bump script failure It was trying to run `.replace` on a Buffer instead of a string. --- .ci/make.mjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.ci/make.mjs b/.ci/make.mjs index 305f066e2..b4b1bb7d6 100644 --- a/.ci/make.mjs +++ b/.ci/make.mjs @@ -86,10 +86,10 @@ async function bump (args) { 'utf8' ) - const pipeline = await readFile(join(import.meta.url, '..', '.buildkite', 'pipeline.yml')) + const pipeline = await readFile(join(import.meta.url, '..', '.buildkite', 'pipeline.yml'), 'utf8') await writeFile( join(import.meta.url, '..', '.buildkite', 'pipeline.yml'), - pipeline.replace(/STACK_VERSION: [0-9]+[0-9\.]*[0-9](?:\-SNAPSHOT)?/, `STACK_VERSION: ${cleanVersion}-SNAPSHOT`), // eslint-disable-line + pipeline.replace(/STACK_VERSION: [0-9]+[0-9\.]*[0-9](?:\-SNAPSHOT)?/, `STACK_VERSION: ${cleanVersion}-SNAPSHOT`), 'utf8' ) } From 9fbedfd87144b0daaad702aa5c0be617f5d7c4b9 Mon Sep 17 00:00:00 2001 From: Josh Mock Date: Thu, 2 Nov 2023 11:35:36 -0500 Subject: [PATCH 2/2] Correctly set Node version in Docker --- .ci/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/Dockerfile b/.ci/Dockerfile index 1f10aed8c..cf5ff29a6 100644 --- a/.ci/Dockerfile +++ b/.ci/Dockerfile @@ -1,4 +1,4 @@ -ARG NODE_JS_VERSION=18 +ARG NODE_JS_VERSION=${NODE_JS_VERSION:-18} FROM node:${NODE_JS_VERSION} ARG BUILDER_UID=1000