-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an ES Module entrypoint for @elastic/elasticsearch #1743
Comments
This issue is stale because it has been open 90 days with no activity. Remove the |
Still relevant. We've got Deno/Bun.js support on the long-term roadmap. I recently merged #1281 to explicitly declare the library as a CommonJS package, but improving to include ESM support will be an important step toward multi-runtime compatibility. |
FYI: I'm able to use |
This issue is stale because it has been open 90 days with no activity. Remove the |
4 months ago it was said it is still relevant |
thanks for your patience, @karfau. I was on leave for 2 months, just getting back to addressing open issues now. |
This issue is stale because it has been open 90 days with no activity. Remove the |
This issue is stale because it has been open 90 days with no activity. Remove the |
At least for more recent deno versions this might have been "resolved" by improved nodejs compatibility... |
It would still be ideal to have good ESM support soon, since that's the unified standard everyone is moving toward. I managed to improve things a bit for |
#2348 This seems to have broken import in ECMAScript modules. |
Fixed in #2475 |
Related to #1281 and #1742.
🚀 Feature Proposal
@elastic/elasticsearch
is currently a CommonJS module. While CommonJS isn't going away any time soon, ECMAScript Modules are very much "the future" of the JavaScript ecosystem. As the community moves in this direction, it may be wise for us to consider moving this library in the same way.To accommodate both CJS and ESM users, we might want to create an ES module wrapper that exports both a CJS and ESM version of the library.
At the very least, as suggested in #1281, it would be good to make the type of the module explicit in
package.json
if we decide to remain with CJS for the time being.Motivation
This will allow the library to work in Deno, and enable asynchronous module loading in Deno and Node.js.
The text was updated successfully, but these errors were encountered: