From a89f71490013989a2688415d53d4404c4dd3d829 Mon Sep 17 00:00:00 2001 From: Josh Mock Date: Wed, 7 Jun 2023 14:27:20 -0500 Subject: [PATCH] Fix broken Github action on Node 14.x (#1904) --- .github/workflows/nodejs.yml | 59 +++++++++++++++++++++--------------- 1 file changed, 34 insertions(+), 25 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 3702b049f..ca00cb372 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -1,3 +1,4 @@ +--- name: Node CI on: [push, pull_request] @@ -8,29 +9,37 @@ jobs: runs-on: ${{ matrix.os }} strategy: + fail-fast: false matrix: node-version: [14.x, 16.x, 18.x, 20.x] os: [ubuntu-latest, windows-latest, macOS-latest] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node-version }} + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node-version }} - - name: Install - run: | - npm install + # workaround for failing tests on Node.js 14.x + # see https://github.com/actions/setup-node/issues/411 + - name: Force install specific npm version + run: | + npm install --global npm@8.3.1 + npm install --global npm@9.7.1 - - name: Lint - run: | - npm run lint + - name: Install + run: | + npm install - - name: Unit test - run: | - npm run test:unit + - name: Lint + run: | + npm run lint + + - name: Unit test + run: | + npm run test:unit license: name: License check @@ -41,17 +50,17 @@ jobs: node-version: [20.x] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node-version }} + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node-version }} - - name: Install - run: | - npm install + - name: Install + run: | + npm install - - name: License checker - run: | - npm run license-checker + - name: License checker + run: | + npm run license-checker