Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup manifest packaging #6540

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pchila
Copy link
Member

@pchila pchila commented Jan 17, 2025

What does this PR do?

This PR decouples dependency version (what is called in the packaging code BEAT_VERSION) from SNAPSHOT and VERSION_QUALIFIER specified for elastic-agent package version.

What works:

  • building an alpha1 version of 9.0.0 starting from SNAPSHOT manifest

    MANIFEST_URL="https://snapshots.elastic.co/9.0.0-7ab33a91/manifest-9.0.0-SNAPSHOT.json" AGENT_DROP_PATH=build/elastic-agent-drop AGENT_PACKAGE_VERSION="9.0.0-alpha1" BEAT_VERSION="9.0.0-SNAPSHOT" VERSION_QUALIFIER="alpha1" PLATFORMS="linux/amd64" mage -v clean downloadManifest package
    
  • building an alpha1 version of 9.0.0 starting from 8.17.1 staging manifest

    MANIFEST_URL="https://staging.elastic.co/8.17.1-f2b43bf6/manifest-8.17.1.json" AGENT_DROP_PATH=build/elastic-agent-drop AGENT_PACKAGE_VERSION="9.0.0-alpha1" BEAT_VERSION="8.17.1" VERSION_QUALIFIER="alpha1"  mage -v clean downloadManifest package
    

What doesn't work:

  • packaging a dev elastic agent using external SNAPSHOT dependencies
    EXTERNAL=true PLATFORMS="linux/amd64" mage -v clean  package
    
    The calculated name of artifacts contains -SNAPSHOT-SNAPSHOT and needs to be fixed

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team chore Tasks that just need to be done, they are neither bug, nor enhancements labels Jan 17, 2025
@pchila pchila self-assigned this Jan 17, 2025
Copy link
Contributor

mergify bot commented Jan 17, 2025

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 17, 2025

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 17, 2025
@pchila pchila linked an issue Jan 17, 2025 that may be closed by this pull request
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify chore Tasks that just need to be done, they are neither bug, nor enhancements Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check support for prerelease qualifiers
1 participant