Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add GH workflow to trigger remote validation #3306

Open
brokensound77 opened this issue Dec 8, 2023 · 4 comments
Open

[FR] Add GH workflow to trigger remote validation #3306

brokensound77 opened this issue Dec 8, 2023 · 4 comments
Labels
backlog enhancement New feature or request

Comments

@brokensound77
Copy link
Contributor

brokensound77 commented Dec 8, 2023

Taking advantage of #3281, we can add a GH workflow to trigger when a label is added and be able to run remote validation on a PR against every rule being changed (ES|QL or EQL only).

  • for PR targeting main, trigger on label: remote-validate (or similar)
  • parse the git diff and extract rules added or modified
  • filter to ES|QL and EQL rules
  • run the code against the list of rules

Dependencies:

  • existing, pre-configured stack
  • creds stored in GH secrets (envvar to point to those creds)
@brokensound77
Copy link
Contributor Author

actually, I think a better option would be to trigger it with a comment on keywords such as test: remote validate

@Mikaayenson
Copy link
Contributor

I linked these to the two metas, as there is some overlap.

@botelastic
Copy link

botelastic bot commented Feb 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale 60 days of inactivity label Feb 6, 2024
@botelastic
Copy link

botelastic bot commented Feb 13, 2024

This has been closed due to inactivity. If you feel this is an error, please re-open and include a justifying comment.

@botelastic botelastic bot closed this as completed Feb 13, 2024
@brokensound77 brokensound77 reopened this Feb 13, 2024
@botelastic botelastic bot removed the stale 60 days of inactivity label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants