Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit default TBS storage size limit sampling.tail.storage_size #14933

Open
Tracked by #14931
carsonip opened this issue Dec 12, 2024 · 1 comment
Open
Tracked by #14931

Revisit default TBS storage size limit sampling.tail.storage_size #14933

carsonip opened this issue Dec 12, 2024 · 1 comment

Comments

@carsonip
Copy link
Member

sampling.tail.storage_size has a default of 3GB which is usually insufficient for high throughput use cases. A storage limit too low will cause TBS to be bypassed and other downstream effects. Reconsider the default in 9.0 release.

@carsonip
Copy link
Member Author

I have 2 ideas for the new default.

  • to allow infinite disk usage
  • to detect available disk space (on startup / periodically) and set the limit dynamically

The argument for either of them is that e.g. if you are running a mysql server, you expect it to use storage space but you don't expect yourself updating a "storage limit" every time it gets hit.

The argument for a detection is to avoid causing a node to be unhealthy in any environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant