Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit 1024 char limit on label values #14721

Open
carsonip opened this issue Nov 25, 2024 · 3 comments
Open

Revisit 1024 char limit on label values #14721

carsonip opened this issue Nov 25, 2024 · 3 comments

Comments

@carsonip
Copy link
Member

carsonip commented Nov 25, 2024

There is a 1024 character (as in unicode characters) limit on string label values, on otlp (see code) and intakev2, because we used to depend on Beats & Fleet to set up mappings which would both set ignore_above: 1024 on keyword fields. As apm-server has migrated to ES apm-data plugin, revisit this limitation on label value.

#14716 is a related issue to handle an inconsistency in enforcing this limit.

@carsonip carsonip changed the title Revisit 1024 char limit for label values Revisit 1024 char limit on label values Nov 25, 2024
@inge4pres
Copy link
Contributor

AFAIR OpenTelemetry is also enforcing some limits on the Attributes key/value length?
Is it true? If yes, how do we discern the APM format, if we'd need to?

@carsonip
Copy link
Member Author

AFAIR OpenTelemetry is also enforcing some limits on the Attributes key/value length?

There is truncation for OTel attributes but default truncation length is unlimited by default: https://opentelemetry.io/docs/specs/otel/common/#attribute-limits

@kruskall
Copy link
Member

A few things discovered while working on this:

  • labels are not the only fields limited to 1024 as pointed out above
  • this is not just otlp. Intake also has fields limited to 1024
  • while it's true that apm-data is no longer using ignore_above, the new otel-data plugin is using ignore_above: 1024 in quite a few places

Given the above, I wonder if we should consistently remove the 1024 limit everywhere. WDYT ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants