Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to make queue part of RabbitMQ transaction names #3421

Closed
Cortana7 opened this issue Nov 9, 2023 · 2 comments
Closed

Add option to make queue part of RabbitMQ transaction names #3421

Cortana7 opened this issue Nov 9, 2023 · 2 comments
Labels
agent-java community Issues and PRs created by the community triage

Comments

@Cortana7
Copy link
Contributor

Cortana7 commented Nov 9, 2023

Is your feature request related to a problem?

It is possible to have multiple Events which are sent to the same exchange.
Therefore it may be difficult to distinguish the transactions if the exchange is used as part of the name.

Describe the solution you'd like

As a solution it would be great to have a configuration option, so that it is possible to use the queue as a part of the transaction name instead of the exchange.

Additional context

There is a similair feature request from @JonasKunz in the issue #3415
With the difference, that he would like to use routing key as part of the name.
He proposed an enum-like configuration option (e.g. rabbitmq_naming_mode).
This would fit very well as it could then be extended to have 3 modes (exchange, queue and routing-key).

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Nov 9, 2023
Cortana7 added a commit to Cortana7/apm-agent-java that referenced this issue Nov 9, 2023
Cortana7 added a commit to Cortana7/apm-agent-java that referenced this issue Nov 13, 2023
Cortana7 added a commit to Cortana7/apm-agent-java that referenced this issue Nov 13, 2023
@Cortana7 Cortana7 changed the title Add option to make queue part of RabbitMQ transactions Add option to make queue part of RabbitMQ transaction names Nov 15, 2023
Cortana7 added a commit to Cortana7/apm-agent-java that referenced this issue Jan 16, 2024
Co-authored-by: Jonas Kunz <[email protected]>
Cortana7 added a commit to Cortana7/apm-agent-java that referenced this issue Jan 16, 2024
Cortana7 pushed a commit to Cortana7/apm-agent-java that referenced this issue Jan 16, 2024
Cortana7 added a commit to Cortana7/apm-agent-java that referenced this issue Jan 16, 2024
jackshirazi pushed a commit that referenced this issue Feb 7, 2024
* #3421 extend spring rabbit transactions to use either queue or exchange in the name

* #3421 tests for naming mode queue

* #3421 updated CHANGELOG.asciidoc

* #3421 added tag

Co-authored-by: Jonas Kunz <[email protected]>

* #3421 improved config-option documentation

Co-authored-by: Jonas Kunz <[email protected]>

* #3421 generated documentation

* Regenerate docs

---------

Co-authored-by: Jonas Kunz <[email protected]>
Co-authored-by: Jonas Kunz <[email protected]>
@JonasKunz
Copy link
Contributor

Implemented in #3424 .

@Cortana7
Copy link
Contributor Author

Thanks a lot for the support. This feature is really helping us a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community triage
Projects
None yet
Development

No branches or pull requests

2 participants