[ebounty] ebounty may repeatedly invoke bigshot while resting

[gs4-Mertyn]

Script Name

ebounty

Bug Report

Occasionally I'll see ebounty repeatedly invoking bigshot in loop while the character should be resting. I encounter this under these conditions:

1. The character just turned in a bounty so his mind is currently Saturated
2. The character just grabbed a new bounty for a creature which is not listed in the Profiles tab
3. EBounty "Keep Hunting" is enabled

The crux of the issue is that the command ";bigshot single" returns immediately since the mind is Saturated. Then, it seems that the loop in EBounty.keep_hunting() will just spin and repeatedly invoke bigshot over and over again.

Expected Behavior

No response

Current Behavior

No response

Possible Solution

One possibility would be to change ";bigshot single" so that it would first let the character fully rest, then complete a hunt, prior to exiting.

Alternatively, ebounty could wait until the character is rested before launching bigshot in the first place.

[gs4-Mertyn]

This isn't a problem only with keep_hunting() and ";bigshot single". I run into the same issue when I'm am saturated and have a new creature bounty that is listed in my Profiles tab. EBounty gets stuck in a repeating loop of invoking ";bigshot bounty". In this case, "bigshot bounty" finishes immediately because the character's mind is fried. I had settings[:exp_pause] disabled at the time, so should_hunt?() was not checking for my percentmind(), and EBounty.data.wait was false. So in this case it seems like should_hunt?() was returning true, then "bigshot bounty" would run and immediately exit with "Exiting: Bounty mode - fried", then the cycle would repeat.

Not sure yet if both cases are the same root cause or not. It seems like the keep_hunting() case isn't checking should_hunt?() at all in the first place.