Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing #1056

Merged
merged 9 commits into from
Nov 18, 2024
Merged

Fix publishing #1056

merged 9 commits into from
Nov 18, 2024

Conversation

elalish
Copy link
Owner

@elalish elalish commented Nov 18, 2024

Looks like our npm and PyPI publishing workflows failed again. The npm one failed because it didn't pick up our artifacts - I'm taking a shot in the dark that bumping our actions versions might help.

There seem to be two different problems for Python, which are more baffling. Ubuntu works, and MacOS works for almost everything, but its x86_64 wheel is failing saying it needs 'arm64e' or 'arm64', which seems odd. And the the SDist failed because apparently CMake can't manage to add the test, samples, or extras directories (??). Seems to work fine everywhere else...

@pca006132 any thoughts?

@pca006132
Copy link
Collaborator

pca006132 commented Nov 18, 2024

The SDist problem is due to some of the directories being excluded, but forgot to make cmake skip those directories when building the SDist.

@pca006132
Copy link
Collaborator

@pca006132
Copy link
Collaborator

I feel like publish NPM failure is caused by improper CI dependency, which caused deployment issues previously. I triggered the job manually and it works now :)

@pca006132
Copy link
Collaborator

I wonder if the python CI problem is caused by us trying to run some python script during cross-compilation, which uses a version of python incompatible with the architecture. I can look at it later today.

@elalish
Copy link
Owner Author

elalish commented Nov 18, 2024

Damn, our WASM is twice as fast and half the size for this release! Nice to see that up on npm. I'm going to bed - I'll check in on the PyPI situation in the morning. Thanks for looking into it.

@hrgdavor
Copy link

Damn, our WASM is twice as fast and half the size for this release! Nice to see that up on npm. I'm going to bed - I'll check in on the PyPI situation in the morning. Thanks for looking into it.

woooooooooooow that is a massive improvement. Thank you for all the hard work.

@pca006132 pca006132 merged commit f22435f into master Nov 18, 2024
27 checks passed
@pca006132 pca006132 deleted the fixPublish branch November 18, 2024 10:01
@pca006132
Copy link
Collaborator

The action will automatically deploy to pypi, I guess we should make a version that doesn't do that later to verify before release.

@elalish
Copy link
Owner Author

elalish commented Nov 18, 2024

The action will automatically deploy to pypi, I guess we should make a version that doesn't do that later to verify before release.

That sounds reasonable if you have a plan for how to verify it. Thoughts?

@pca006132
Copy link
Collaborator

Just see if it builds?

@elalish
Copy link
Owner Author

elalish commented Nov 19, 2024

Oh, I thought it wouldn't successfully deploy unless it built anyway. Wasn't that was happened here before this PR?

@pca006132
Copy link
Collaborator

Yeah, but we can check if our PR can be built successfully before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants