-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix publishing #1056
Fix publishing #1056
Conversation
The SDist problem is due to some of the directories being excluded, but forgot to make cmake skip those directories when building the SDist. |
Manually triggering https://github.com/elalish/manifold/actions/runs/11886656652 |
I feel like publish NPM failure is caused by improper CI dependency, which caused deployment issues previously. I triggered the job manually and it works now :) |
I wonder if the python CI problem is caused by us trying to run some python script during cross-compilation, which uses a version of python incompatible with the architecture. I can look at it later today. |
Damn, our WASM is twice as fast and half the size for this release! Nice to see that up on npm. I'm going to bed - I'll check in on the PyPI situation in the morning. Thanks for looking into it. |
woooooooooooow that is a massive improvement. Thank you for all the hard work. |
The action will automatically deploy to pypi, I guess we should make a version that doesn't do that later to verify before release. |
That sounds reasonable if you have a plan for how to verify it. Thoughts? |
Just see if it builds? |
Oh, I thought it wouldn't successfully deploy unless it built anyway. Wasn't that was happened here before this PR? |
Yeah, but we can check if our PR can be built successfully before merging. |
Looks like our npm and PyPI publishing workflows failed again. The npm one failed because it didn't pick up our artifacts - I'm taking a shot in the dark that bumping our actions versions might help.
There seem to be two different problems for Python, which are more baffling. Ubuntu works, and MacOS works for almost everything, but its x86_64 wheel is failing saying it needs 'arm64e' or 'arm64', which seems odd. And the the SDist failed because apparently CMake can't manage to add the
test
,samples
, orextras
directories (??). Seems to work fine everywhere else...@pca006132 any thoughts?