Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests #6

Open
memclutter opened this issue Oct 21, 2016 · 5 comments
Open

Unit tests #6

memclutter opened this issue Oct 21, 2016 · 5 comments
Assignees
@memclutter

Comments

@memclutter
Copy link
Contributor

memclutter commented Oct 21, 2016 •
edited
Loading

This task is very important. Before improvement, need to have a test case, because that way we will be sure that nothing is broken 😄

See https://phpunit.de/ for more details.

I can help with the writing and the organization run automatically on https://travis-ci.org/
ekinhbayar pushed a commit that referenced this issue Oct 21, 2016
Progress on #6
5b01df7
ekinhbayar pushed a commit that referenced this issue Oct 21, 2016
Merge pull request #9 from ekinhbayar/tests
2cff181 
Progress on #6 Adding phpunit
@memclutter
Copy link
Contributor Author

Good. I am ready to start this task. Please put me as assignee, so that others know that the task is carried out by someone.

ekinhbayar pushed a commit that referenced this issue Oct 22, 2016
@memclutter
Write first unit tests for issue #6 (#16)
34c820d
@PeeHaa
Copy link
Collaborator

PeeHaa commented Oct 22, 2016

Can you also set up the .travis.yml config file @memclutter using phpdbg? So that it we can have code coverage reports for both 7.0 as well as 7.1?

Otherwise let me know and I will set up the config file.

Thanks!

@joruro joruro mentioned this issue Oct 22, 2016
Closed
@memclutter
Copy link
Contributor Author

ok, I will do soon

@PeeHaa
Copy link
Collaborator

PeeHaa commented Oct 22, 2016

Awesome 👍

ekinhbayar pushed a commit that referenced this issue Oct 23, 2016
@memclutter
Issue6 unittests (#21)
2d2e5ee 
* Write first unit tests for issue #6

* Travis CI file

* Update travis file

* Add EOF
@PeeHaa
Copy link
Collaborator

PeeHaa commented Oct 27, 2016

I will start writing the rest of the test this week so we can close this issue and start having a look at a proper refactoring.

@PeeHaa PeeHaa mentioned this issue Oct 30, 2016
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@memclutter memclutter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PeeHaa @ekinhbayar @memclutter