Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass detrended_flux and detrended_flux_err directly to constructor #68

Open
ekaterinailin opened this issue May 20, 2021 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ekaterinailin
Copy link
Owner

At the moment, you can only pass 'flux' and 'flux_err' to 'FlareLightCurve'.

What needs to be created or improved?

We also want to pass 'detrended_flux' and 'detrended_flux_err' to 'FlareLightCurve' directly, too.

Can you provide an example?

This is how it works now:

lc = FlareLightCurve(data['TIME'])
lc["detrended_flux"] = data['detrended_flux']
lc["detrended_flux_err"] = data['detrended_flux_err']

# OR

lc = FlareLightCurve(data, targetid=999)
# data can be a simple dict or an astropy Table

This is how we may want it to work, too:

lc = FlareLightCurve(data['TIME'], detrended_flux=data['detrended_flux'], detrended_flux_err=data['detrended_flux_err'], )

What is the goal / expected behaviour?

@ekaterinailin ekaterinailin added enhancement New feature or request good first issue Good for newcomers labels May 20, 2021
@chantalshine
Copy link

Hello!

I would like the opportunity to work on this issue.

@toihr
Copy link

toihr commented Dec 1, 2021

Is this still worked on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants