Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR title/body gets overwritten on updates/merges #435

Open
rohan-mehta opened this issue Dec 28, 2024 · 0 comments · May be fixed by #436
Open

PR title/body gets overwritten on updates/merges #435

rohan-mehta opened this issue Dec 28, 2024 · 0 comments · May be fixed by #436

Comments

@rohan-mehta
Copy link

This is a copy of #236. To summarize, if you create a PR and then edit the PR on the github web interface (e.g. to upload images, add markdown, use the preview etc), git spr update overwrites those changes when you update the PR.

@lukas-mertens suggested this fix, which I'm going to implement:

it would indeed be nice if spr would only replace what it created before. That is pretty easy to do actually and done like that by other tools as well. GitHub supports html comments, so you can just do the following:

All the spr stuff here
<!-- SPR Description End: Don't edit anything inside or it will be lost -->

And then you just do a replace inside those two hardcoded strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant