From efa3623cf50067ecb4b9e28f8108c404e43cdaa2 Mon Sep 17 00:00:00 2001 From: Bannerets Date: Sat, 7 Oct 2023 16:50:11 +0000 Subject: [PATCH] publish-tdl.yml: Move to centos:7 devtoolset-9 Move from prebuild/centos7-devtoolset7 to centos:7 with devtoolset-9 (the same version Holy Build Box uses, which is used in prebuilt-tdlib). This image has a newer gcc version, hopefully fixing a compilation error that was present with gcc 7. Note: We don't link libstdc++ statically to reduce the binary size (about 1.1M with statically linked libstdc++) and consequently the npm package size. This is the same as before this commit, since prebuildify-cross links libstdc++ dynamically as well. --- .github/workflows/publish-tdl.yml | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish-tdl.yml b/.github/workflows/publish-tdl.yml index 092ea76..f2b1579 100644 --- a/.github/workflows/publish-tdl.yml +++ b/.github/workflows/publish-tdl.yml @@ -27,13 +27,28 @@ jobs: run: npm install - name: Clean old binaries run: npm run clean -w tdl - # prebuildify-cross doesn't work with npm workspaces - name: Prebuildify in docker if: runner.os == 'Linux' run: | - docker run -u root -v $(pwd):/app ghcr.io/prebuild/centos7-devtoolset7:2 \ - npm run make-prebuild -w tdl -- --tag-libc - tree packages/tdl + # docker run -u root -v $(pwd):/app ghcr.io/prebuild/centos7-devtoolset7:2 \ + # npm run make-prebuild -w tdl -- --tag-libc + cat > prebuilt-node-addon.sh <