Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks using ddsim instead of npsim #30

Open
sly2j opened this issue Sep 4, 2024 · 0 comments
Open

Benchmarks using ddsim instead of npsim #30

sly2j opened this issue Sep 4, 2024 · 0 comments

Comments

@sly2j
Copy link
Contributor

sly2j commented Sep 4, 2024

eg:

physics_benchmarks/benchmarks/dis/Snakefile

Line 19 in 9a878fb

ddsim \

Using ddsim does not enable Cherenkov photons. This is fine for now (we're using the LUT), but will cause issues down the line.

Solution: replace ddsim with npsim. Also consider updating the npsim setup to be consistent with what the Productions WG uses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sly2j