sciann_datagenerator.py generates more samples than asked ?

[florian-dupont]

Dear Ehsan,

Thanks a lot for your fantastic work !

Just a small remark, I didn't really understand why the sciann_generator.py generates more samples than asked when I called DataGeneratorXY or DataGeneratorXYT class.
Finally, I think there is a problem in the generate_data function and especially with the generated data for the last boundary conditions (top edge) and I would replace

x_bc_top = np.random.uniform(self.Xdomain[0], self.Xdomain[1], num_sample-num_sample_per_edge)
y_bc_top = np.full(num_sample-num_sample_per_edge, self.Ydomain[1])

by
x_bc_top = np.random.uniform(self.Xdomain[0], self.Xdomain[1], num_sample_per_edge)
y_bc_top = np.full(num_sample_per_edge, self.Ydomain[1])

for both class.

Thanks

PS : Has someone already tried to add parametric variable in input of the PINN (material properties for example in order to create "a parametric solution") ? If yes, I would be interested to speak about it !

Florian