Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The characteristic of the field in Jubjub.hs isn't a prime number! #42

Closed
kwxm opened this issue Oct 20, 2019 · 2 comments
Closed

The characteristic of the field in Jubjub.hs isn't a prime number! #42

kwxm opened this issue Oct 20, 2019 · 2 comments
Labels

Comments

@kwxm
Copy link
Collaborator

kwxm commented Oct 20, 2019

I don't have time time fix this at the moment, but I just noticed that the number 5243587517512619047944774050818596583769055250052763782260365869993858118451352435875175126190479447740508185965837690552500527637822603658699938581184513

in Jubjub.hs isn't prime. If you look closely it's the same number repeated twice, so it's equal to
52435875175126190479447740508185965837690552500527637822603658699938581184513 * 100000000000000000000000000000000000000000000000000000000000000000000000000001

Oops.

I think I must have accidentally clicked twice while pasting at some point. This adds some force to the suggestion in #36 that we should have a test to make sure that characteristics are actually prime.

@effectfully
Copy link
Owner

5243587517512619047944774050818596583769055250052763782260365869993858118451352435875175126190479447740508185965837690552500527637822603658699938581184513

But it's not what in the Jubjub module? It's

52435875175126190479447740508185965837690552500527637822603658699938581184513

there.

I just checked, the number there is equal to r, i.e. it's the correct one.

@kwxm
Copy link
Collaborator Author

kwxm commented Oct 21, 2019

Oh. I was experimenting with the type in there a little and maybe I pasted it in twice when I was doing that.

Sorry for the false alarm.

@kwxm kwxm closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants