Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty-printing #30

Open
effectfully opened this issue Sep 18, 2019 · 4 comments
Open

Pretty-printing #30

effectfully opened this issue Sep 18, 2019 · 4 comments
Assignees
@jakzale
Labels
Textual representation

Comments

@effectfully
Copy link
Owner

Currently we just dump expressions as Strings using some custom functions. We should use a proper pretty-printing library and be agnostic about the final string type. Precedence and associativity of operators should also be taken into account.

I've started writing a suitable library (mostly by extracting various pieces from the plutus-core codebase).
@jakzale jakzale mentioned this issue Mar 17, 2020
Merged
@jakzale
Copy link
Collaborator

jakzale commented Mar 17, 2020

Add a separate pretty printing pass for golden testing.

@jakzale jakzale self-assigned this Mar 31, 2020
@jakzale
Copy link
Collaborator

jakzale commented Jul 31, 2020

@effectfully was the pretty printing library released?

@effectfully
Copy link
Owner Author

Nope, but we can directly depend on the prettyprinter-configurable subfolder of the Plutus repo.

@jakzale
Copy link
Collaborator

jakzale commented Aug 3, 2020

Urgh, got hit by commercialhaskell/stack#5004

Do you have anything against git submodules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakzale jakzale

Labels
Textual representation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakzale @effectfully