Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load fore from node modules #37

Open
line-o opened this issue Oct 6, 2023 · 1 comment · May be fixed by #38
Open

load fore from node modules #37

line-o opened this issue Oct 6, 2023 · 1 comment · May be fixed by #38
Assignees
@JoernT

Comments

@line-o
Copy link
Member

line-o commented Oct 6, 2023

The Fore library is currently included as a copy in src/resources/js/fore-all.js
The version is not clear.
It is bundled with lit-element version 1.4.1 judging from its contents. I don't know if that is still the case with more recent versions.

Loading a version form node modules would make it

  • obvious which version is used
  • easier to update fore in the future
@line-o
Copy link
Member Author

line-o commented Oct 6, 2023

related Fore issue Jinntec/Fore#231

@line-o line-o linked a pull request Oct 6, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernT JoernT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load fore dependency from npm eeditiones/tuttle
2 participants
@JoernT @line-o