Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish-still looks like draft #45

Open
lehudgins opened this issue Jan 20, 2014 · 6 comments
Open

publish-still looks like draft #45

lehudgins opened this issue Jan 20, 2014 · 6 comments
Assignees
Labels

Comments

@lehudgins
Copy link
Collaborator

Once you hit publish it returns you to the previous page, which is good, but the published item still has a red dotted outline like a draft.

@ghost ghost assigned edrex Jan 20, 2014
@edrex
Copy link
Owner

edrex commented Jan 20, 2014

Thanks, this is a known issue but evidently I didn't create a bug for it yet.

It goes away after a page reload because it is just a failure to cascade updates. I believe a $scope.digest() call is needed.

@edrex
Copy link
Owner

edrex commented Jan 20, 2014

this should be fixed now. when you publish, you'll be sent to the previous page, and the new page will show up once it arrives from the server. Ideally I'd like to send the user directly to the newly-published page, but that is tricky because it takes a bit to show up.

@edrex
Copy link
Owner

edrex commented Jan 22, 2014

@lehudgins fixed?

@lehudgins
Copy link
Collaborator Author

Not sure. I had to reload before it appeared. When it appeared it did look like a published item rather than a draft.

On Tue, Jan 21, 2014 at 9:25 PM, Eric Drechsel [email protected]:

@lehudgins https://github.com/lehudgins fixed?


Reply to this email directly or view it on GitHubhttps://github.com//issues/45#issuecomment-32994449
.

@edrex
Copy link
Owner

edrex commented Jan 22, 2014

yeah, the UI updates seem broken again. I need to circle back and write more E2E tests so we don't keep having regressions like this. Thanks

@edrex
Copy link
Owner

edrex commented Jan 22, 2014

Part of it is me (re)learning angular. The work I did today on the login flow helped me figure out how to robustly propogate updates in Angular (using broadcast events)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants