Syncing with edx/frontend-component-header for Sumac
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
hinakhadim
added a commit
that referenced
this pull request
Nov 19, 2024
* fix: update header with openedx v5.5.0 for sumac upgrade * fix: update mobile header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The redwood/indigo version currently in use was taken from v5.2.0. Since Sumac branches are scheduled to cut off on October 23rd, we are syncing it with the latest version, v5.5.0, of the @edx/frontend-component-header.
The reasons for this update are:
Learner Dashboard Compatibility:
The learner-dashboard in Redwood does not support the @edx/frontend-header package and currently uses a local header package. In Sumac, it will transition to using the @edx/frontend-header package. To ensure compatibility with the learner-dashboard, we are upgrading it to align with version v5.5.0, as this version works seamlessly with the dashboard.
Future MFE Support:
The updated header supports all MFEs. This will help avoid merge conflicts and reduce maintenance efforts in future updates.