Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Nauticus Controller Fails to Update Space on Resource Quota Override Edit #49

Open
smileisak opened this issue Nov 19, 2023 · 3 comments
Assignees
Labels
blocked-needs-validation Issue need tirage and validation bug Something isn't working lifecycle/frozen

Comments

@smileisak
Copy link
Member

Bug description

Issue: When creating a space from a template with resource quota override, the initial creation works as expected. However, subsequent edits to the space, specifically updating the overridden resource quota values, do not prompt any reaction or update from the nauticus-controller.

How to reproduce

Steps to reproduce the behavior:

  1. Set Up a Kind Cluster: Initialize a new kind cluster for testing.
  2. Apply the Space Template: Use the space template provided in config/samples to set up the initial space.
  3. Apply the Space Override: Implement a resource quota override on the created space.
  4. Edit the Space: Use kubectl edit to modify the space, particularly changing a resource quota value.

Expected behavior

The expected behavior is that the nauticus-controller should detect changes made to the space's resource quota and update accordingly. This should include applying the new quota values to the space.

Logs

If applicable, please provide logs of nauticus-controller.

Nothing happens, so there is no logs.

Additional context

Nauticus version: v0.2.0
Helm Chart version: v0.2.0
Kubernetes version: v1.27.2

@smileisak smileisak added bug Something isn't working blocked-needs-validation Issue need tirage and validation labels Nov 19, 2023
Copy link

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #nauticus on Kubernetes Slack.

@abelhoula
Copy link
Collaborator

After thoroughly reviewing the steps you've outlined and attempting to reproduce the issue within the specified environment, I've found that the controller behaves as expected, responding appropriately to the resource quota modifications.

Copy link

github-actions bot commented Mar 8, 2024

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #nauticus on Kubernetes Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-needs-validation Issue need tirage and validation bug Something isn't working lifecycle/frozen
Projects
None yet
Development

No branches or pull requests

2 participants