Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of wasm (via one-ini) causes failures on some systems #128

Open
Colengms opened this issue Nov 7, 2024 · 2 comments
Open

Use of wasm (via one-ini) causes failures on some systems #128

Colengms opened this issue Nov 7, 2024 · 2 comments

Comments

@Colengms
Copy link

Colengms commented Nov 7, 2024

We'd like to be able to use the editorconfig module in the C/C++ Extension for VS Code. However, it's inclusion currently results in the following issue for some of our users: microsoft/vscode-cpptools#12529

The issue would appear to be related to inclusion of wasm, which is pulled in by one-ini, which is used by editorconfig. The issue is fully resolved if we omit the editorconfig module from our project.

However, it's trickly to replicate the behavior, particularly glob matching against section patterns. Would it be possible to avoid the dependency on one-ini and wasm? Or, alternatively, could someone point me to (TypeScript) code I might use to match section patterns? (The tricky part seems to be the numeric ranges).

@hildjj
Copy link
Collaborator

hildjj commented Nov 8, 2024

We had a whole discussion about one-ini and the wasm therein and made an explicit decision to go that way. Let's see if we can fix one-ini's WASM, which is likely broken in several ways since I'm not at all a WASM or Rust expert.

I've opened an issue there, and will follow up here with releases as we try to find this.

@hildjj
Copy link
Collaborator

hildjj commented Nov 8, 2024

I'm working on a patch to this project with @one-ini/wasm v0.1.2. It's going to take a while because there are a bunch of new tests that fail in editorconfig-core-test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants