Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube channels with spaces in name will not work #119

Open
qbabooba opened this issue Jan 19, 2024 · 0 comments
Open

Youtube channels with spaces in name will not work #119

qbabooba opened this issue Jan 19, 2024 · 0 comments

Comments

@qbabooba
Copy link

There is an issue with the youtube extraction regex that stops if there is a space in channel name. Eg

https://www.youtube.com/watch?v=kU9y8rKCe3w&ab_channel=Well%2BGood

will not work,

the issue is with regex
(?:https?://)?(?:www.)?(?:(?:youtu.be/)|(?:youtube.com)/(?:v/|u/\w/|embed/|watch))(?:(?:?v=)?([^#&?=]))?((?:[?&]\w=\w*)*)```

that should be rewritten to
(?:https?://)?(?:www.)?(?:(?:youtu.be/)|(?:youtube.com)/(?:v/|u/\w/|embed/|watch))(?:(?:?v=)?([^#&?=]))?((?:[?&]\w=[\w%+]))

qbabooba pushed a commit to qbabooba/embed that referenced this issue Jan 20, 2024
qbabooba added a commit to qbabooba/embed that referenced this issue Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant