Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

Tour Record Display Page - View Videos #55

Open
gmh04 opened this issue Feb 28, 2017 · 6 comments
Open

Tour Record Display Page - View Videos #55

gmh04 opened this issue Feb 28, 2017 · 6 comments
Assignees
@gmh04
Labels
complete low priority
Milestone
Future Roadmap/Ni...

Comments

@gmh04
Copy link
Contributor

gmh04 commented Feb 28, 2017

Display videos on Tour Record page.
@gmh04 gmh04 self-assigned this Feb 28, 2017
gmh04 added a commit that referenced this issue Mar 1, 2017
@gmh04
ad video to tour record page #55
b3a6cfb
jollopre added a commit that referenced this issue Mar 1, 2017
@jollopre
Merge pull request #57 from edina/issue-55-video
177b074 
add video to tour record page #55
@gmh04 gmh04 added the complete label Mar 1, 2017
@NicolaOsborne
Copy link

Moving this to next milestone. Android issue: needs video to play full screen when tapped (As in iOS).

@NicolaOsborne NicolaOsborne modified the milestones: Release 1.0 (Android and iOS) code freeze for testing, Release 0.2 Mid-way release of Android & iOS for initial testing Mar 13, 2017
@gmh04 gmh04 removed the complete label Mar 13, 2017
@gmh04
Copy link
Contributor Author

gmh04 commented Mar 14, 2017 •
edited
Loading

No fullscreen support for WebView on Android: facebook/react-native#5230.

@gmh04
Copy link
Contributor Author

gmh04 commented Mar 14, 2017

@NicolaOsborne could investigate 3rd party plugins, e.g: https://github.com/inProgress-team/react-native-youtube

@gmh04 gmh04 added the feedback label Mar 14, 2017
@NicolaOsborne
Copy link

Thanks @gmh04. React Native YouTube looks promising and is the code every enquiry online seems to point to. Happy to go with this.

@gmh04 gmh04 removed the feedback label Mar 20, 2017
@gmh04
Copy link
Contributor Author

gmh04 commented Mar 21, 2017

Unable to get this plugin working for android, see davidohayon669/react-native-youtube#99. The solution to use an alternative fork ended with the app crashing. By the way, this plugin also requires the native android youtube app to be installed.

@NicolaOsborne with our timescales I would suggest leaving the video player as it is without full screen support on android, at least it works - with no dependency on another native app.

@gmh04 gmh04 added the complete label Mar 24, 2017
@NicolaOsborne
Copy link

Could you please recheck if there is now YouTube support available? (for roadmap)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gmh04 gmh04

Labels
complete low priority
Projects
None yet
Milestone
Future Roadmap/Nice to Have
Development

No branches or pull requests
2 participants
@gmh04 @NicolaOsborne