-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure headers passed to Hackney as case-insensitive? #100
Comments
Hm.. I would open an issue to fix hackney so it looks for cc/ @benoitc |
Yup, indeed. It seems like this existing issue could make it possible: Thanks @edgurgel ! |
@tjsousa Just stumbled across this issue. I’m getting the error:
It’s related to the same one you’ve experienced above. Is there some way to explicitly pass the I also put a StackOverflow question up here for it: http://stackoverflow.com/questions/42210304/elixir-httpoison-no-case-clause-matching-false-error |
Still seeing this issue. |
Has there been any developments here ? |
@tcitworld it has been fixed in hackney. Do you still reproduce the issue? |
You mean by using the hackney_headers module instead ? |
Still seeing this issue (case sensitive headers) in HTTPoison. And, to be honest, having to resort to hackney_headers kind of defeats the purpose of using an Elixir wrapper library. |
Host header is passed once. @facundoolano do you have any example? |
@benoitc I guess my issue is more related to the title than the description. My main problem is that there's no case insensitive way to access response headers, so I need to know how the server sends them to fetch them, or manually downcase all the keys first. |
Closing due to inactivity. Happy to accept a PR to get a header from HTTPoison's module |
I've run into an issue where I'm passing headers (including a
host
header) coming from a Plug's connection intoHTTPoison
, which default to lower-case, thus causing:hackney
to override theHost
header (because it matches a capitalized one).The referred use-case is for an app acting as a reverse-proxy where transparently passing headers, specially the
Host
header is very important.A workaround have been suggested, which I feel would be best implemented at the
httpoison
lib level to avoid this issue for other users as well.What do you guys think?
The text was updated successfully, but these errors were encountered: