Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fairer comparison with SqlAlchemy #67

Open
jsimonlane opened this issue Nov 25, 2023 · 1 comment
Open

Fairer comparison with SqlAlchemy #67

jsimonlane opened this issue Nov 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jsimonlane
Copy link

It looks like the SqlAlchemy uses their own native async engine.

        engine = sa_asyncio.create_async_engine(
            f"postgresql+asyncpg://sqlalch_bench:edgedbbenchmark@"
            f"{ctx.db_host}:{ctx.pg_port}/sqlalch_bench"
        )

If you subbed in your (ie MagicStack's) AsyncPG library instead instead (should be a couple line change), I'd be very curious to see a comparison... that would be a revealing benchmark to see how your EdgeDB Query Optimizer is doing (vs how much of the performance difference is better serialization).

@raddevon raddevon added the enhancement New feature or request label Dec 1, 2023
@raddevon
Copy link

raddevon commented Dec 1, 2023

Would this make sense as either an additional benchmark or even a replacement for the existing SqlAlchemy benchmark, @fantix? If either, I suspect maybe the former would be better since most people would probably use the SqlAlchemy native async engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants