-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Price per block could increase #2
Comments
My understanding is that |
True, but a frequent pattern is to approve an unlimited amount if they expect to repeatedly interact with the contract. Something we should run by experts when the time comes. |
Here:
https://github.com/edgeandnode/subscription-payments-contract/blob/7b0368e4da25ece37440e0999fbeee652ad8b103/contracts/Subscriptions.sol#L90
there is no "defense" to the consumer for the price per block to increase suddenly. This could be used by a malicious entity to drain funds
The text was updated successfully, but these errors were encountered: