Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repack specials fix #6

Open
noxxusnx opened this issue May 12, 2024 · 3 comments
Open

Repack specials fix #6

noxxusnx opened this issue May 12, 2024 · 3 comments

Comments

@noxxusnx
Copy link
Contributor

If a special episode is a repack, the title of the episode is not included, just the "REPACK" tag

@noxxusnx
Copy link
Contributor Author

This appears to be an issue in the guessit library that this script uses to extract video information from a file name.

You can replicate with setting this up:

from guessit import guessit

file_name_original = "Total.Forgiveness.S00E01.Grant.OBrien.Its.All.Love.Full.Stand.up.Set.1080p.DRPO.WEBRip.x265.AAC.2.0-NOXXUS.mkv"
file_name_repack = "Total.Forgiveness.S00E01.REPACK.Grant.OBrien.Its.All.Love.Full.Stand.up.Set.1080p.DRPO.WEBRip.x265.AAC.2.0-NOXXUS.mkv"

Then calling guessit(file_name_original) returns:

MatchesDict({'title': 'Total Forgiveness', 'season': 0, 'episode': 1, 'episode_title': 'Grant OBrien Its All Love Full Stand up Set', 'screen_size': '1080p', 'source': 'Web', 'other': 'Rip', 'video_codec': 'H.265', 'audio_codec': 'AAC', 'audio_channels': '2.0', 'release_group': 'NOXXUS', 'container': 'mkv', 'mimetype': 'video/x-matroska', 'type': 'episode'})

Then calling guessit(file_name_repack) returns:

MatchesDict({'title': 'Total Forgiveness', 'season': 0, 'episode': 1, 'other': ['Proper', 'Rip'], 'proper_count': 1, 'screen_size': '1080p', 'source': 'Web', 'video_codec': 'H.265', 'audio_codec': 'AAC', 'audio_channels': '2.0', 'release_group': 'NOXXUS', 'container': 'mkv', 'mimetype': 'video/x-matroska', 'type': 'episode'})

Noticeably no longer returning a value for episode_title

@noxxusnx
Copy link
Contributor Author

Created an issue for this upstream here guessit-io/guessit#775

@noxxusnx
Copy link
Contributor Author

Created a PR in the upstream library to fix this guessit-io/guessit#788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant