Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 'update-entity' emit events to supply replacement data #270

Open
annybs opened this issue May 8, 2024 · 0 comments
Open

Refactor 'update-entity' emit events to supply replacement data #270

annybs opened this issue May 8, 2024 · 0 comments

Comments

@annybs
Copy link
Member

annybs commented May 8, 2024

Example: 7f2e707

This emit sequence allows a nested component to trigger a reload of server data after the server has been changed. However, there is some redundancy here, because while server is received in the response data for the changed, it isn't passed back to the parent component to substitute; instead, a subsequent GET request is triggered.

We can reduce round trips by refactoring events in several places to allow response data to be passed up the component tree. The API provides consistent response entity data for almost all requests, so very little if anything needs to be done in the backend to make this happen.

This goes hand-in-hand with #238 to reduce avoidable traffic to the API and improve performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant