Skip to content
This repository has been archived by the owner on Jan 6, 2019. It is now read-only.

Landscape #104

Closed
wants to merge 9 commits into from
Closed

Landscape #104

wants to merge 9 commits into from

Conversation

avuton
Copy link

@avuton avuton commented Apr 24, 2017

Hello! I've been commenting recently on a couple of issues, specifically, this branch should fix #103, #93 and #67, and hopefully not break too many unrelated things. This probably fixes #86 as well, I'm not quite sure what was going on with that issue. I intend to be responsive to any issues that arise, time permitting. That said, I've tested it under emulation for API 15, which works fine, and on my tablet, and my phone.

Thanks!

@avuton
Copy link
Author

avuton commented May 6, 2017

Hello @seizonsenryaku. First of all I don't want to come off as impatient, I don't mind how long this process may take (I've been to busy moving to work on this right now too). I would really appreciate knowing if there is an intention to move this work upstream. I love this launcher. I have a queue of commits so far, with no real end in sight.

What I'm working on:

  • Reducing maintenance/translation burden
  • Reducing compiled size
  • General updating where it makes sense
  • Coming up with a code style which fits this code base so the code can be uniform and more easily read
  • Reducing the code lint where it makes sense

What I have no intention of doing:

  • Adding bloat. I love the minimalism of this launcher, I like minimal code. At the same time, when features improve the usefulness, I would consider sending a PR as long as there's a good argument for it
  • I would be completely skeptical about adding permissions of any type as well, unless the feature would come with a completely optional popup and are well explained to the end user. There might be cases where it becomes completely necessary (the PR Apps On sdCards show up (fix of #89) #98 comes to mind at the moment)

One thing I'll say is there is so much well thought out code in here. I am here to help clean it up in any way I can. I really don't want to fork it at all. If there's anything I can do to help move this forward, from changing my commit process (smaller targeted commits?) to code style (I try to finalize most fields and variables so it's obvious at a glance immutable status) or anything else, I'm all ears.

Thanks!

@avuton
Copy link
Author

avuton commented May 9, 2017

Latest push just added multi-window support.

@avuton
Copy link
Author

avuton commented Jun 9, 2017

I'm going to pull this pull request. Our code bases are going to fork too far to try to remerge without /some/ kind of cooperation or communication. At this point, any effort I try to keep this branch mergable is lost energy as long as there's no communication. I'm flexable and I'm willing to bend over backwards to be able to remerge, so feel free to shoot me an email at any time if you'd like to remerge.

@avuton avuton closed this Jun 9, 2017
@avuton avuton deleted the landscape branch June 9, 2017 23:39
avuton referenced this pull request in NeroProtagonist/HayaiLauncher Jul 2, 2017
…onger than 1 character.

- Added option to choose search engine for web search. Current options are Google (default), Bing, Yahoo, StartPage, DuckDuckGo, and Wikipedia.
@avuton avuton mentioned this pull request Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search field remains focused after keyboard is hidden Remove whitespace at the bottom
1 participant