Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior when V > nrow(X) #151

Open
rdiaz02 opened this issue Feb 27, 2024 · 0 comments
Open

Inconsistent behavior when V > nrow(X) #151

rdiaz02 opened this issue Feb 27, 2024 · 0 comments

Comments

@rdiaz02
Copy link

rdiaz02 commented Feb 27, 2024

We can run CV.SuperLearner with innerCvControl = list(list(V = vi)) where vi >> nrow(X) without trouble (it just becomes leave-one-out). Similarly, in SuperLearner we can set cvControl = list(V = vi) where vi >> nrow(X). I think this is a great feature.

However, if in CV.SuperLearner we set cvControl = list(list(V = vi)) with vi > nrow(X) it fails at the very end. I understand why this happens, but instead of erroring at the end it could, somewhere at the top of the function:

  1. Set vi = min(vi, nrow(X))
  2. Give a warning if the control list has been modified.

And it might be appropriate to document it in the help of SuperLearner and CV.SuperLearner.

I can submit a PR if deemed appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant