Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve normalized domain names #56

Open
ziima opened this issue Oct 9, 2018 · 0 comments
Open

Resolve normalized domain names #56

ziima opened this issue Oct 9, 2018 · 0 comments

Comments

@ziima
Copy link

ziima commented Oct 9, 2018

A domain name can be supplied in a number of ways. I found out, that multisite doesn't account for that. For example domain names example.com and example.com. which refer to the same object do not behave as such.

from multisite.models import Alias
Alias.objects.resolve('example.com')  # Returns <Alias: example.com -> example.com>
Alias.objects.resolve('example.com.')  # Returns None

I suggest to convert the domain name into preferred name syntax, see https://tools.ietf.org/html/rfc1035.html#section-2.3.1, before the domain is actually resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant