From b913d9d55cb0a0c64739b9637f63f52399bad5c8 Mon Sep 17 00:00:00 2001
From: Emanuele Danovaro <emanuele.danovaro@ecmwf.int>
Date: Fri, 15 Sep 2023 11:35:50 +0100
Subject: [PATCH] FDB-319 added metadata validation on archival

---
 src/fdb5/database/Archiver.cc |  5 ++++-
 src/fdb5/rules/Rule.cc        | 13 ++++++++++++-
 src/fdb5/rules/Rule.h         |  2 ++
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/src/fdb5/database/Archiver.cc b/src/fdb5/database/Archiver.cc
index 682fdc9b0..2053e5151 100644
--- a/src/fdb5/database/Archiver.cc
+++ b/src/fdb5/database/Archiver.cc
@@ -47,11 +47,14 @@ void Archiver::archive(const Key &key, BaseArchiveVisitor& visitor) {
 
     dbConfig_.schema().expand(key, visitor);
 
-    if (visitor.rule() == nullptr) { // Make sure we did find a rule that matched
+    const Rule* rule = visitor.rule();
+    if (rule == nullptr) { // Make sure we did find a rule that matched
         std::ostringstream oss;
         oss << "FDB: Could not find a rule to archive " << key;
         throw eckit::SeriousBug(oss.str());
     }
+    // validate metadata
+    rule->check(key);
 }
 
 void Archiver::flush() {
diff --git a/src/fdb5/rules/Rule.cc b/src/fdb5/rules/Rule.cc
index 1d627c8fb..bd4717222 100644
--- a/src/fdb5/rules/Rule.cc
+++ b/src/fdb5/rules/Rule.cc
@@ -20,7 +20,7 @@
 #include "fdb5/rules/Schema.h"
 #include "fdb5/database/ReadVisitor.h"
 #include "fdb5/database/WriteVisitor.h"
-
+#include "fdb5/types/Type.h"
 
 namespace fdb5 {
 
@@ -494,6 +494,17 @@ const Schema &Rule::schema() const {
     return schema_;
 }
 
+void Rule::check(const Key& key) const {
+    for (const auto& pred : predicates_ ) {
+        auto k = key.find(pred->keyword());
+        if (k != key.end()) {
+            const std::string& value = (*k).second;
+            const Type& type = registry_.lookupType(pred->keyword());
+            ASSERT(value == type.tidy(pred->keyword(), value));
+        }
+    }
+}
+
 std::ostream &operator<<(std::ostream &s, const Rule &x) {
     x.print(s);
     return s;
diff --git a/src/fdb5/rules/Rule.h b/src/fdb5/rules/Rule.h
index ab30b8c22..b9f877ecf 100644
--- a/src/fdb5/rules/Rule.h
+++ b/src/fdb5/rules/Rule.h
@@ -83,6 +83,8 @@ class Rule : public eckit::NonCopyable {
     const Schema &schema() const;
     const TypesRegistry &registry() const;
 
+    void check(const Key& key) const;
+
 private: // methods
 
     void expand(const metkit::mars::MarsRequest &request,