Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_field_wrapdataslice failure #44

Open
DJDavies2 opened this issue Jun 27, 2024 · 2 comments
Open

test_field_wrapdataslice failure #44

DJDavies2 opened this issue Jun 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@DJDavies2
Copy link
Contributor

What happened?

This test fails like this:

105: /spice/scratch/frwd/cylc-run/mi-be984/work/1/git_clone_atlas/atlas/src/tests/field/fctest_field_wrap.F90:121: warning: FCTEST_CHECK_EQUAL(data(i,j,l) , real(1000i+100j+10*k+l,c_double) )
105: --> [ 1.1210000000000000E+03 != 1.1120000000000000E+03 ]

What are the steps to reproduce the bug?

Build with NAG and run this ctest.

Version

head of develop

Platform (OS and architecture)

Linux, nagfor

Relevant log output

No response

Accompanying data

No response

Organisation

Met Office

@DJDavies2 DJDavies2 added the bug Something isn't working label Jun 27, 2024
@DJDavies2
Copy link
Contributor Author

I don't know if there is a solution for this. I think the code as it stands isn't standard conforming; the implementation relies on this:

stridesf = array_strides(data)

in atlas_Field__wrap_ pass data by reference but there is nothing in the Fortran standard that guarantees that; it can be passed via copy in/copy out and it seems that this is what nag is doing.

@DJDavies2
Copy link
Contributor Author

Sorry, I should clarify, the test failure above is actually at atlas test failure. So perhaps this should be opened there. However I think the fckit code is problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant