Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests access undefined proto_var variable #3123

Open
mattst88 opened this issue Oct 5, 2024 · 0 comments
Open

Some tests access undefined proto_var variable #3123

mattst88 opened this issue Oct 5, 2024 · 0 comments

Comments

@mattst88
Copy link

mattst88 commented Oct 5, 2024

These test scripts all contain a finally: block that attempts to print proto_ver which does not exist:

  • test/broker/02-subpub-qos1-message-expiry.py
  • test/broker/02-subpub-qos1-message-expiry-retain.py
  • test/broker/02-subpub-qos1-message-expiry-will.py
  • test/broker/02-subpub-qos2-pubrec-error.py
print("proto_ver=%d" % (proto_ver))

This mistake appears to be a copy-and-paste error in commit b2a9daf ("02 broker subpub tests with v5 support").

As a fix, I suggest:

  1. s/proto_ver=5/proto_ver=proto_ver/g
  2. s/do_test():/do_test(proto_ver):/g
  3. s/do_test()/do_test(proto_ver=5)/g

I'd submit a patch, but the CLA process is too much for what is a single sed invocation.

sed -i \
	-e 's/proto_ver=5/proto_ver=proto_ver/g' \
	-e 's/do_test():/do_test(proto_ver):/g' \
	-e 's/do_test()/do_test(proto_ver=5)/g' \
	test/broker/02-subpub-qos1-message-expiry.py \
	test/broker/02-subpub-qos1-message-expiry-retain.py \
	test/broker/02-subpub-qos1-message-expiry-will.py \
	test/broker/02-subpub-qos2-pubrec-error.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant