LSP4E context menu Format action should not be allowed in read-only documents

[rubenporras]

Currently, if you open a read-only file and try to perform any of the Format action, the contents of the file will appear to change.

Note that it is not possible to save the file with these modifications.

Nevertheless, it should not be possible to apply commenting to a read-only document, even just at the UI level, if the document is read only, the menu item should be disabled, as for the delete/copy actions in the screenshot.

Probably same problem and same pattern for the fix as in eclipse/tm4e#789

[sebthom]

If we just disable the menu the user does not know the reason. I think instead we should display the dialog you get when you try to manually modify a read-only file:

[rubenporras]

I would prefer the greyed out behavior for TM4E, just because it is the same as for all of the menu items contributed by the editor (and I guess it is also easier to implement).

Regarding the dialog, thanks for the screenshot. I have never seen it :). I guess you can only have that dialog if you actually have the rights to make the file writable, or can it happen that you press "Yes" and it fails? That would not be a good user experience, otherwise I think it is a good idea but, if we plan to do the same for the items contributed by the editor (to me consistency is more important)