Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The generate-vscode-jars profile should not include lemminx jar and its dependencies #529

Open
fbricon opened this issue Nov 10, 2023 · 4 comments

Comments

@fbricon
Copy link
Contributor

fbricon commented Nov 10, 2023

When running mvn clean verify -DskipTests -Dinvoker.skip=true -Pgenerate-vscode-jars, the lemminx jar and its dependencies (including tests), should be excluded.

@vrubezhny
Copy link
Contributor

@fbricon then how are we going run lemminx-maven in vscode-xml?

@fbricon
Copy link
Contributor Author

fbricon commented Nov 10, 2023

Vscode-xml already provides lemminx and its dependencies. We only need lemminix-maven and its own specific dependencies

@vrubezhny
Copy link
Contributor

@fbricon I think this is still a question in case of vscode-xml is set to use a lemminx binary

@fbricon
Copy link
Contributor Author

fbricon commented Nov 10, 2023

no, the lemminx uber jar is always shipped in vcode-xml, whether you use the binary or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants