chore: modify the threshold of StorageRelatedTasks and add file delet…

…ion log
eclipse · Oct 21, 2023 · a6f31af · a6f31af
1 parent 3575a91
commit a6f31af
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/server/src/main/java/org/eclipse/jifa/server/service/impl/FileServiceImpl.java b/server/src/main/java/org/eclipse/jifa/server/service/impl/FileServiceImpl.java
@@ -59,6 +59,7 @@
 import java.nio.file.Path;
 import java.time.Instant;
 import java.util.List;
+import java.util.Optional;
 import java.util.UUID;
 import java.util.concurrent.TimeUnit;
 
@@ -286,7 +287,12 @@ public NamedResource handleDownloadRequest(long fileId) throws Throwable {
 
     @Override
     public void deleteOldestFile() {
-        fileRepo.findFirstByOrderByCreatedTimeDesc().ifPresent(this::doDelete);
+        Optional<FileEntity> optional = fileRepo.findFirstByOrderByCreatedTimeDesc();
+        if (optional.isPresent()) {
+            FileEntity file = optional.get();
+            doDelete(file);
+            log.info("File '{} ({})' is deleted", file.getOriginalName(), file.getUniqueName());
+        }
     }
 
     private FileEntity getFileEntityByIdAndCheckAuthority(long id) {

diff --git a/server/src/main/java/org/eclipse/jifa/server/task/StorageRelatedTasks.java b/server/src/main/java/org/eclipse/jifa/server/task/StorageRelatedTasks.java
@@ -44,7 +44,7 @@ public class StorageRelatedTasks extends ConfigurationAccessor {
 
     private final StorageService storageService;
 
-    private static final double THRESHOLD = 0.15;
+    private static final double THRESHOLD = 0.05;
 
     public StorageRelatedTasks(LockSupport lockSupport,
                                FileRepo fileRepo,