Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional unit tests for compaction #1086

Open
Eddykasp opened this issue Nov 6, 2024 · 0 comments
Open

Add additional unit tests for compaction #1086

Eddykasp opened this issue Nov 6, 2024 · 0 comments
Labels
alg-layered Affects the ELK Layered algorithm. chore Comparatively mindless work that has to be done. enhancement An improvement to existing functionality. tests Affects unit tests and the test framework

Comments

@Eddykasp
Copy link
Contributor

Eddykasp commented Nov 6, 2024

The current unit tests for graph compaction only test whether the compaction algorithms work correctly on the CGraph but not whether this also correctly maps back to the original graph and all its elements.

This can cause issues such as this #1081 to remain undetected.
@Eddykasp Eddykasp added enhancement An improvement to existing functionality. alg-layered Affects the ELK Layered algorithm. tests Affects unit tests and the test framework chore Comparatively mindless work that has to be done. labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
alg-layered Affects the ELK Layered algorithm. chore Comparatively mindless work that has to be done. enhancement An improvement to existing functionality. tests Affects unit tests and the test framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eddykasp